Hi android building !
I used to have this in one of my Android.mk makefiles : $(shell (cd $(LOCAL_PATH)/../../ && ./pre-build-script.sh)) but I just noticed that this practice is now discouraged on the Soong Android.bp build system >From the Build System Best Practices <https://android.googlesource.com/platform/build/soong/+/HEAD/docs/best_practices.md> document, I could read : Don't use $(shell) to write files, create symlinks, etc. We expect to enforce this in the future. Encode these as build rules in the build graph instead. This can be problematic in a number of ways: Could you give me a concrete example of how I could run this "pre-build-script.sh" shell script before *every* build in my new Android.bp file ? thx :) *Frederic Plourde* Principal Engineer Collabora ltd. -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/1131b0a7-0656-4813-9226-c233f3c2a05c%40googlegroups.com.
