The hidl module types create new modules behind the scenes, and likely aren't forwarding the notice property. Can you file a bug at https://issuetracker.google.com/issues/new?component=381517 ? I can route it appropriately.
Thanks, Dan On Thu, Nov 29, 2018 at 9:40 AM Sascha Effert <[email protected]> wrote: > Hi Dan, > > thanks, I found my problem. The Android.bp files containing the cc_library > and cc_binary entries I am adding are in subdirectories under the directory > that contains my NOTICE file. Therefore they have not been detected > correctly. I added now a > notice: "../../NOTICE", > and everything works as expected. > > I also added the enty to my hidl_interface and hidl_package_root > definition, but the shared lib generated for my HIDL Interface is not added > to the NOTICE.xml.gz. Do you have an idea what could be missing there? > > bests > > Sascha > > > Am Donnerstag, 29. November 2018 00:17:11 UTC+1 schrieb Dan Willemsen: >> >> Is this a shared library (*.so installed)? >> >> The NOTICE file is the one that matters here, it needs to be in the same >> directory as the Android.mk or Android.bp defining the library. You can >> also specify one explicitly using `notice: "filename",` or >> `LOCAL_NOTICE_FILE := filename`. >> >> - Dan >> >> On Wed, Nov 28, 2018 at 7:06 AM Sascha Effert <[email protected]> >> wrote: >> >>> Hello, >>> >>> I added a new lib into our vendor HAL using soong. This is already >>> running, it is part of our vendor Image and we can use it. The only problem >>> left: added files or notmentioned in vendor.xml.gz in vendor/etc/, so the >>> license information is missing. What is the way to get it in? >>> >>> I had a look into some other part of the AOSP (e.g. external/wayland) >>> and saw that there is always an empty file starting with MODULE_LICENSE_ >>> (e.g. MODULE_LICENSE_GPL) and a file NOTICE with the lcense text. I added a >>> file MODULE_LICENSE_BIOS and a file NOTICE with our license text to the lib >>> directory, but it did not help. >>> >>> Is there somewhere an example how to add something to AOSP, so the >>> license files are handled in the right way? >>> >>> bests >>> >>> Sascha >>> >>> -- >>> -- >>> You received this message because you are subscribed to the "Android >>> Building" mailing list. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/android-building?hl=en >>> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Android Building" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > -- > You received this message because you are subscribed to the "Android > Building" mailing list. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/android-building?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "Android Building" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
