[AMD Official Use Only - General]

Reviewed-by: Asad Kamal <[email protected]<mailto:[email protected]>>

Thanks & Regards
Asad

From: Wang, Yang(Kevin) <[email protected]>
Sent: Wednesday, November 15, 2023 8:42 AM
To: Lazar, Lijo <[email protected]>; [email protected]
Cc: Zhang, Hawking <[email protected]>; Deucher, Alexander 
<[email protected]>; Kamal, Asad <[email protected]>; Ma, Le 
<[email protected]>
Subject: Re: [PATCH] drm/amd/pm: Don't send unload message for reset


[AMD Official Use Only - General]

Reviewed-by: Yang Wang <[email protected]<mailto:[email protected]>>

Best Regards,
Kevin
________________________________
From: Lazar, Lijo <[email protected]<mailto:[email protected]>>
Sent: Wednesday, November 15, 2023 11:04
To: [email protected]<mailto:[email protected]> 
<[email protected]<mailto:[email protected]>>
Cc: Zhang, Hawking <[email protected]<mailto:[email protected]>>; 
Deucher, Alexander 
<[email protected]<mailto:[email protected]>>; Kamal, Asad 
<[email protected]<mailto:[email protected]>>; Ma, Le 
<[email protected]<mailto:[email protected]>>; Wang, Yang(Kevin) 
<[email protected]<mailto:[email protected]>>
Subject: [PATCH] drm/amd/pm: Don't send unload message for reset

No need to notify about unload during reset. Also remove the FW version
check.

Signed-off-by: Lijo Lazar <[email protected]<mailto:[email protected]>>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index b51cd9e50e64..d431553ad8b8 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -1500,7 +1500,7 @@ static int smu_v13_0_6_register_irq_handler(struct 
smu_context *smu)

 static int smu_v13_0_6_notify_unload(struct smu_context *smu)
 {
-       if (smu->smc_fw_version <= 0x553500)
+       if (amdgpu_in_reset(smu->adev))
                 return 0;

         dev_dbg(smu->adev->dev, "Notify PMFW about driver unload");
--
2.25.1

Reply via email to