[Public] > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Mario > Limonciello > Sent: Monday, October 23, 2023 9:45 AM > To: [email protected] > Cc: Limonciello, Mario <[email protected]>; > [email protected] > Subject: [PATCH] drm/amd: Disable ASPM for VI w/ all Intel systems > > Originally we were quirking ASPM disabled specifically for VI when used with > Alder Lake, but it appears to have problems with Rocket Lake as well. > > Like we've done in the case of dpm for newer platforms, disable ASPM for all > Intel systems. > > Cc: [email protected] # 5.15+ > Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") > Reported-and-tested-by: Paolo Gentili <[email protected]> > Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742 > Signed-off-by: Mario Limonciello <[email protected]>
Reviewed-by: Alex Deucher <[email protected]> As a follow on, we probably want to apply this to all of the program_aspm() functions for each asic family. Alex > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c > b/drivers/gpu/drm/amd/amdgpu/vi.c index 6a8494f98d3e..fe8ba9e9837b > 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1124,7 +1124,7 @@ static void vi_program_aspm(struct > amdgpu_device *adev) > bool bL1SS = false; > bool bClkReqSupport = true; > > - if (!amdgpu_device_should_use_aspm(adev) || > !amdgpu_device_aspm_support_quirk()) > + if (!amdgpu_device_should_use_aspm(adev) || > +!amdgpu_device_pcie_dynamic_switching_supported()) > return; > > if (adev->flags & AMD_IS_APU || > -- > 2.34.1
