Applied. Thanks! Alex
On Tue, Oct 10, 2023 at 2:32 AM Wang, Yang(Kevin) <[email protected]> wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Yang Wang <[email protected]> > > Best Regards, > Kevin > > -----Original Message----- > From: Kunwu.Chan <[email protected]> > Sent: Tuesday, October 10, 2023 2:11 PM > To: Wang, Yang(Kevin) <[email protected]> > Cc: Deucher, Alexander <[email protected]>; Kamal, Asad > <[email protected]>; Koenig, Christian <[email protected]>; Zhang, > Hawking <[email protected]>; Ma, Le <[email protected]>; Lazar, Lijo > <[email protected]>; Pan, Xinhui <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: [PATCH] drm/amd/pm: Fix a memory leak on an error path > > Add missing free on an error path. > > Fixes: 511a95552ec8 ("drm/amd/pm: Add SMU 13.0.6 support") > Signed-off-by: Kunwu.Chan <[email protected]> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > index ce971a93d28b..c26e12ff532c 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > @@ -1981,8 +1981,10 @@ static ssize_t smu_v13_0_6_get_gpu_metrics(struct > smu_context *smu, void **table > > metrics = kzalloc(sizeof(MetricsTable_t), GFP_KERNEL); > ret = smu_v13_0_6_get_metrics_table(smu, metrics, true); > - if (ret) > + if (ret) { > + kfree(metrics); > return ret; > + } > > smu_cmn_init_soft_gpu_metrics(gpu_metrics, 1, 3); > > -- > 2.25.1 >
