Applied. Thanks! Alex
On Wed, Sep 27, 2023 at 2:57 PM Wang, Yang(Kevin) <[email protected]> wrote: > > [AMD Official Use Only - General] > > Thanks. > > Reviewed-by: Yang Wang <[email protected]> > > Best Regards, > Kevin > > -----Original Message----- > From: Dan Carpenter <[email protected]> > Sent: Wednesday, September 27, 2023 8:38 PM > To: Evan Quan <[email protected]>; Wang, Yang(Kevin) <[email protected]> > Cc: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie > <[email protected]>; Daniel Vetter <[email protected]>; Lazar, Lijo > <[email protected]>; Kamal, Asad <[email protected]>; Zhang, Hawking > <[email protected]>; Wang, Yang(Kevin) <[email protected]>; > [email protected]; [email protected] > Subject: [PATCH] drm/amd/pm: delete dead code > > "ret" was checked earlier inside the loop, so we know it is zero here. > No need to check a second time. > > Signed-off-by: Dan Carpenter <[email protected]> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > index 11a6cd96c601..0ffe55e713f3 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > @@ -2346,9 +2346,6 @@ static int mca_get_mca_entry(struct amdgpu_device > *adev, enum amdgpu_mca_error_t > return ret; > } > > - if (ret) > - return ret; > - > entry->idx = idx; > entry->type = type; > > -- > 2.39.2 >
