Applied. Thanks!
On Thu, Sep 14, 2023 at 5:53 AM Zhang, Hawking <[email protected]> wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Hawking Zhang <[email protected]> > > Regards, > Hawking > -----Original Message----- > From: Cong Liu <[email protected]> > Sent: Thursday, September 14, 2023 17:46 > To: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie > <[email protected]>; Daniel Vetter <[email protected]>; Yang, Stanley > <[email protected]>; Zhang, Hawking <[email protected]> > Cc: Cong Liu <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [PATCH] fix a memory leak in amdgpu_ras_feature_enable > > This patch fixes a memory leak in the amdgpu_ras_feature_enable() function. > The leak occurs when the function sends a command to the firmware to enable > or disable a RAS feature for a GFX block. If the command fails, the kfree() > function is not called to free the info memory. > > Fixes: bf7aa8bea9cb ("drm/amdgpu: Free ras cmd input buffer properly") > Signed-off-by: Cong Liu <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index 8eb6f6943778..b4a8ea946410 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -802,6 +802,7 @@ int amdgpu_ras_feature_enable(struct amdgpu_device *adev, > enable ? "enable":"disable", > get_ras_block_str(head), > amdgpu_ras_is_poison_mode_supported(adev), > ret); > + kfree(info); > return ret; > } > > -- > 2.34.1 >
