If new range is added to update list, splited to multiple pranges with
max_svm_range_pages alignment, and svm validate and map returns error
for the first prange, then the caller retry should add pranges with
prange->is_error_flag or prange without prange->mapped_to_gpu to the
update list, to update GPU mapping for the entire range.

Fixes: c22b04407097 ("drm/amdkfd: flag added to handle errors from svm validate 
and map")
Signed-off-by: Philip Yang <[email protected]>
Tested-by: James Zhu <[email protected]>
---
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 61dd66bddc3c..8871329e9cbd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -825,7 +825,7 @@ svm_range_is_same_attrs(struct kfd_process *p, struct 
svm_range *prange,
                }
        }
 
-       return !prange->is_error_flag;
+       return true;
 }
 
 /**
@@ -2228,7 +2228,8 @@ svm_range_add(struct kfd_process *p, uint64_t start, 
uint64_t size,
                next = interval_tree_iter_next(node, start, last);
                next_start = min(node->last, last) + 1;
 
-               if (svm_range_is_same_attrs(p, prange, nattr, attrs)) {
+               if (!prange->is_error_flag && prange->mapped_to_gpu &&
+                   svm_range_is_same_attrs(p, prange, nattr, attrs)) {
                        /* nothing to do */
                } else if (node->start < start || node->last > last) {
                        /* node intersects the update range and its attributes
-- 
2.35.1

Reply via email to