On 7/31/23 12:08, Mario Limonciello wrote:
Some systems are only connected by HDMI or DP, so warning related to
missing eDP is unnecessary.  Downgrade to debug instead.

Cc: Hamza Mahfooz <[email protected]>
Fixes: 6d9b6dceaa51 ("drm/amd/display: only warn once in 
dce110_edp_wait_for_hpd_ready()")
Reported-and-tested-by: [email protected]
Signed-off-by: Mario Limonciello <[email protected]>
---
  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 
b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 20d4d08a6a2f3..3ce3d3367b288 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -777,7 +777,8 @@ void dce110_edp_wait_for_hpd_ready(
        dal_gpio_destroy_irq(&hpd);
/* ensure that the panel is detected */
-       ASSERT(edp_hpd_high);
+       if (!edp_hpd_high)
+               BREAK_TO_DEBUGGER();

Can you print a message using DC_LOG_DC() here instead?

  }
void dce110_edp_power_control(
--
Hamza

Reply via email to