Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data

Thu, 13 Jul 2023 09:08:03 -0700 


On 7/13/23 06:21, Miguel Ojeda wrote:
> On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann <[email protected]> wrote:
>>
>> Most fbdev drivers depend on framebuffer_alloc() to initialize the
>> allocated memory to 0. Document this guarantee.
>>
>> Suggested-by: Miguel Ojeda <[email protected]>
>> Signed-off-by: Thomas Zimmermann <[email protected]>
>> Cc: Helge Deller <[email protected]>
> 
> Thanks for sending this! Maybe this would be best earlier in the
> series, so that later patches make more sense (since they use the
> guarantee), but it is not a big deal.
> 
>> + * aligned to sizeof(long). Both, the instance of struct fb_info and
>> + * the driver private data, are cleared to zero.
> 
> I think both commas may be best omitted (but I am not a native speaker).

Yes, it would be better to omit them.

> Reviewed-by: Miguel Ojeda <[email protected]>
> 
> Cheers,
> Miguel

-- 
~Randy























					Reply via email to