[Public] Hi Michel,
You confirmed in another thread the monitor specific quirk for disabling FAMS fixed your hang. Fixes references the commit which adds such quirk: de1da2f7fe25 drm/amd/display: Add monitor specific edid quirk The intention is that these two patches should only be merged into stable trees after applying the monitor specific quirk. -- Regards, Jay ________________________________ From: Michel Dänzer <[email protected]> Sent: Thursday, July 6, 2023 6:05 AM To: Pillai, Aurabindo <[email protected]>; [email protected] <[email protected]> Cc: Chalmers, Wesley <[email protected]>; Siqueira, Rodrigo <[email protected]>; Wheeler, Daniel <[email protected]>; Mahfooz, Hamza <[email protected]>; Deucher, Alexander <[email protected]>; Wentland, Harry <[email protected]> Subject: Re: [PATCH 1/2] drm/amd/display: Do not set drr on pipe commit On 7/5/23 20:07, Aurabindo Pillai wrote: > From: Wesley Chalmers <[email protected]> > > [WHY] > Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a > pipe commit can cause underflow. > > [HOW] > Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets > optimized_required. > > This change expects that Freesync requests are blocked when > optimized_required is true. > > Fixes: de1da2f7fe25 ("drm/amd/display: Add monitor specific edid quirk") Seems like inappropriate use of Fixes:, or how does this commit "fix" the referenced commit? (Also a bit surprised to learn about that one only now, and that it landed without my confirming it actually works) -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer
