On Tue, May 30, 2023 at 5:17 AM Srinivasan Shanmugam <[email protected]> wrote: > > Fix these warnings by adding 'inst' arguments to kdocs. > > gcc with W=1 > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:428: warning: Function parameter or > member 'inst' not described in 'gmc_v7_0_flush_gpu_tlb_pasid' > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:626: warning: Function parameter or > member 'inst' not described in 'gmc_v8_0_flush_gpu_tlb_pasid' > drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:423: warning: Function parameter or > member 'inst' not described in 'gmc_v10_0_flush_gpu_tlb_pasid' > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c:328: warning: Function parameter or > member 'inst' not described in 'gmc_v11_0_flush_gpu_tlb_pasid' > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:950: warning: Function parameter or > member 'inst' not described in 'gmc_v9_0_flush_gpu_tlb_pasid' > > Cc: Christian König <[email protected]> > Cc: Alex Deucher <[email protected]> > Cc: Hawking Zhang <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c > index 01bd45651382..1f9313298030 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c > @@ -414,6 +414,7 @@ static void gmc_v10_0_flush_gpu_tlb(struct amdgpu_device > *adev, uint32_t vmid, > * @pasid: pasid to be flush > * @flush_type: the flush type > * @all_hub: Used with PACKET3_INVALIDATE_TLBS_ALL_HUB() > + * @inst: is used to select which xcc's register to program
Update the documentation to something like: + * @inst: is used to select which instance of KIQ to use for the invalidation With that fixed for all of these, the patch is: Reviewed-by: Alex Deucher <[email protected]> > * > * Flush the TLB for the requested pasid. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c > index 4bf807d825c0..8e78bcd92b59 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c > @@ -319,6 +319,7 @@ static void gmc_v11_0_flush_gpu_tlb(struct amdgpu_device > *adev, uint32_t vmid, > * @pasid: pasid to be flush > * @flush_type: the flush type > * @all_hub: flush all hubs > + * @inst: is used to select which xcc's register to program > * > * Flush the TLB for the requested pasid. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > index 6f53049619cd..4d4a6957ea00 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > @@ -419,6 +419,7 @@ static int gmc_v7_0_mc_init(struct amdgpu_device *adev) > * @pasid: pasid to be flush > * @flush_type: type of flush > * @all_hub: flush all hubs > + * @inst: is used to select which xcc's register to program > * > * Flush the TLB for the requested pasid. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > index 48475077ca92..a5d47e4d0a8d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c > @@ -617,6 +617,7 @@ static int gmc_v8_0_mc_init(struct amdgpu_device *adev) > * @pasid: pasid to be flush > * @flush_type: type of flush > * @all_hub: flush all hubs > + * @inst: is used to select which xcc's register to program > * > * Flush the TLB for the requested pasid. > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index be7823d82150..5200303e63de 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -941,6 +941,7 @@ static void gmc_v9_0_flush_gpu_tlb(struct amdgpu_device > *adev, uint32_t vmid, > * @pasid: pasid to be flush > * @flush_type: the flush type > * @all_hub: flush all hubs > + * @inst: is used to select which xcc's register to program > * > * Flush the TLB for the requested pasid. > */ > -- > 2.25.1 >
