[AMD Official Use Only - General]


-----Original Message-----
From: SHANMUGAM, SRINIVASAN <[email protected]> 
Sent: Monday, April 10, 2023 11:02 PM
To: Wentland, Harry <[email protected]>; Zuo, Jerry <[email protected]>; 
Li, Sun peng (Leo) <[email protected]>; Deucher, Alexander 
<[email protected]>
Cc: [email protected]; SHANMUGAM, SRINIVASAN 
<[email protected]>
Subject: [PATCH v2] drm/amd/display: Add logging for DP link traning Test 
Pattern Seqeunces

Add some more logging for DP link traning test pattern seqeunces for better 
debugging.

Cc: Jerry Zuo <[email protected]>
Cc: Harry Wentland <[email protected]>
Cc: Leo Li <[email protected]>
Cc: Alex Deucher <[email protected]>
Signed-off-by: Srinivasan Shanmugam <[email protected]>
---
v2:

 - it is better to use : instead of \n, following the log format in default 
section (Jerry)
 - seems no need to print dpcd_tr_pattern if it is already mentioned in the 
string (Jerry)

 .../drm/amd/display/dc/link/protocols/link_dp_training.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c 
b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
index 70fc0ddf2d7e..265233979cf8 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c
@@ -212,27 +212,36 @@ enum dpcd_training_patterns
 
        switch (pattern) {
        case DP_TRAINING_PATTERN_SEQUENCE_1:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern TPS1\n", 
+__func__);
                dpcd_tr_pattern = DPCD_TRAINING_PATTERN_1;
                break;
        case DP_TRAINING_PATTERN_SEQUENCE_2:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern TPS2\n", 
+__func__);
                dpcd_tr_pattern = DPCD_TRAINING_PATTERN_2;
                break;
        case DP_TRAINING_PATTERN_SEQUENCE_3:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern TPS3\n", 
+__func__);
                dpcd_tr_pattern = DPCD_TRAINING_PATTERN_3;
                break;
        case DP_TRAINING_PATTERN_SEQUENCE_4:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern TPS4\n", 
+__func__);
                dpcd_tr_pattern = DPCD_TRAINING_PATTERN_4;
                break;
        case DP_128b_132b_TPS1:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b training 
pattern 
+TPS1\n", __func__);
                dpcd_tr_pattern = DPCD_128b_132b_TPS1;
                break;
        case DP_128b_132b_TPS2:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b training 
pattern 
+TPS2\n", __func__);
                dpcd_tr_pattern = DPCD_128b_132b_TPS2;
                break;
        case DP_128b_132b_TPS2_CDS:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP 128b/132b training 
pattern TPS2 CDS\n",
+                                       __func__);
                dpcd_tr_pattern = DPCD_128b_132b_TPS2_CDS;
                break;
        case DP_TRAINING_PATTERN_VIDEOIDLE:
+               DC_LOG_HW_LINK_TRAINING("%s: Using DP training pattern 
videoidle\n", 
+__func__);
                dpcd_tr_pattern = DPCD_TRAINING_PATTERN_VIDEOIDLE;
                break;
        default:
--
2.25.1

Reply via email to