[AMD Official Use Only - General] Btw, if the concern is the gfx_late_init failure caused by incorrect setting in IFWI. @Feng, Kenneth already have a workaround.
Regards, Hawking -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Zhang, Hawking Sent: Thursday, November 3, 2022 14:46 To: Wang, YuBiao <[email protected]>; [email protected] Cc: Xiao, Jack <[email protected]>; Wang, Yang(Kevin) <[email protected]>; Xu, Feifei <[email protected]>; Chen, Horace <[email protected]>; Tuikov, Luben <[email protected]>; Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>; Koenig, Christian <[email protected]>; Liu, Monk <[email protected]> Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case [AMD Official Use Only - General] amdgpu_ras_feature_enable won't send RAS command to firmware if it is invoked from guest side. The change seems unnecessary. Regards, Hawking -----Original Message----- From: Wang, YuBiao <[email protected]> Sent: Thursday, November 3, 2022 14:39 To: Wang, YuBiao <[email protected]>; [email protected]; Zhang, Hawking <[email protected]> Cc: Quan, Evan <[email protected]>; Chen, Horace <[email protected]>; Tuikov, Luben <[email protected]>; Koenig, Christian <[email protected]>; Deucher, Alexander <[email protected]>; Xiao, Jack <[email protected]>; Liu, Monk <[email protected]>; Xu, Feifei <[email protected]>; Wang, Yang(Kevin) <[email protected]> Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case Hi Hawking, This patch is to skip ras init in sriov case. Please help review. Thanks, Yubiao -----Original Message----- From: YuBiao Wang <[email protected]> Sent: Thursday, November 3, 2022 11:12 AM To: [email protected] Cc: Andrey Grodzovsky <[email protected]>; Quan, Evan <[email protected]>; Chen, Horace <[email protected]>; Tuikov, Luben <[email protected]>; Koenig, Christian <[email protected]>; Deucher, Alexander <[email protected]>; Xiao, Jack <[email protected]>; Zhang, Hawking <[email protected]>; Liu, Monk <[email protected]>; Xu, Feifei <[email protected]>; Wang, Yang(Kevin) <[email protected]>; Wang, YuBiao <[email protected]> Subject: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case In sriov guest side doesn't need init ras feature, so skip it. Signed-off-by: YuBiao Wang <[email protected]> --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index 84a76c36d9a7..be8ed617e269 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c @@ -4707,7 +4707,7 @@ static int gfx_v11_0_late_init(void *handle) if (r) return r; - if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(11, 0, 3)) { + if (!amdgpu_sriov_vf(adev) && adev->ip_versions[GC_HWIP][0] == IP_VERSION(11, 0, 3)) { r = gfx_v11_0_ras_late_init(handle); if (r) return r; -- 2.25.1
