Re: [PATCH 05/13] drm/amdgpu: drop amdgpu_sync from amdgpu_vmid_grab

[Christian König]

Am 23.10.22 um 03:25 schrieb Luben Tuikov:
On 2022-10-14 04:46, Christian König wrote:
[SNIP]
@@ -254,12 +254,10 @@ static struct dma_fence *amdgpu_job_dependency(struct 
drm_sched_job *sched_job,
                        DRM_ERROR("Error adding fence (%d)\n", r);
        }
  
-	while (fence == NULL && vm && !job->vmid) {
-               r = amdgpu_vmid_grab(vm, ring, &job->sync, job);
+       while (fence == NULL && job->vm && !job->vmid) {
In preliminary application of the patch series, checkpatch.pl complains about 
comparison to NULL,
and wants !fence, instead:
        while (!fence && job->vm && !job->vmid) {

I can see that it had been like this before... and I know it's out of the scope 
of this series,
but we should fix this at some point in time.

Thanks for pointing that out. I try to fix it whenever I encounter 
something like this, but sometimes just forget to double check.

Thanks,
Christian.


Regards,
Luben