[AMD Official Use Only - General] Series is
Reviewed-by: Hawking Zhang <[email protected]> Regards, Hawking From: Chai, Thomas <[email protected]> Date: Thursday, September 8, 2022 at 16:43 To: [email protected] <[email protected]> Cc: Chai, Thomas <[email protected]>, Zhang, Hawking <[email protected]>, Zhou1, Tao <[email protected]>, Wang, Yang(Kevin) <[email protected]>, Chai, Thomas <[email protected]> Subject: [PATCH V3 3/3] drm/amd/pm: Remove redundant check condition V3: [Why]: Since ASICs using smu v13_0_2 have called smu .suspend before calling amdgpu_pm_sysfs_fini, pm.dpm_enabled was already set to 0 when smu .suspend was called. This makes it impossible to delete all pm sys nodes. [How]: Since all functions in amdgpu_pm_sysfs_fini have their own condition checks, so the first conditional check in amdgpu_pm_sysfs_fini can be removed. Signed-off-by: YiPeng Chai <[email protected]> --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index 5e318b3f6c0f..948cc75376f8 100644 --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c @@ -3405,9 +3405,6 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev) void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev) { - if (adev->pm.dpm_enabled == 0) - return; - if (adev->pm.int_hwmon_dev) hwmon_device_unregister(adev->pm.int_hwmon_dev); -- 2.25.1
