[Public] > -----Original Message----- > From: Liu, Shaoyun <[email protected]> > Sent: July 28, 2022 1:10 PM > To: Kim, Jonathan <[email protected]>; amd- > [email protected] > Cc: Kim, Jonathan <[email protected]> > Subject: RE: [PATCH] drm/amdgpu: fix hive reference leak when reflecting > psp topology info > > [AMD Official Use Only - General] > > Looks good to me . > BTW , why we didn't catch it on baremetal mode ?
Thanks for the review Shaoyun. Good question. I'll double check what we're doing for unload testing. Thanks, Jon > > Reviewed-by: Shaoyun.liu <[email protected]> > > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of > Jonathan Kim > Sent: Thursday, July 28, 2022 1:06 PM > To: [email protected] > Cc: Kim, Jonathan <[email protected]> > Subject: [PATCH] drm/amdgpu: fix hive reference leak when reflecting psp > topology info > > Hives that require psp topology info to be reflected will leak hive reference > so fix it. > > Signed-off-by: Jonathan Kim <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index 3ee363bfbac2..6c23e89366bf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > @@ -1292,6 +1292,8 @@ static void psp_xgmi_reflect_topology_info(struct > psp_context *psp, > > break; > } > + > + amdgpu_put_xgmi_hive(hive); > } > > int psp_xgmi_get_topology_info(struct psp_context *psp, > -- > 2.25.1 >
