feel free to add Reviewed-by: Jingwen Chen <[email protected]>
On 7/14/22 10:31 AM, lin cao wrote: > In the case of SRIOV, the register smnMp1_PMI_3_FIFO will get an invalid > value which will cause the "shift out of bound". In Ubuntu22.04, this > issue will be checked an related call trace will be reported in dmesg. > > Signed-off-by: lin cao <[email protected]> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > index b71860e5324a..fa520d79ef67 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > @@ -886,6 +886,7 @@ static void sienna_cichlid_stb_init(struct smu_context > *smu); > > static int sienna_cichlid_init_smc_tables(struct smu_context *smu) > { > + struct amdgpu_device *adev = smu->adev; > int ret = 0; > > ret = sienna_cichlid_tables_init(smu); > @@ -896,7 +897,8 @@ static int sienna_cichlid_init_smc_tables(struct > smu_context *smu) > if (ret) > return ret; > > - sienna_cichlid_stb_init(smu); > + if (!amdgpu_sriov_vf(adev)) > + sienna_cichlid_stb_init(smu); > > return smu_v11_0_init_smc_tables(smu); > }
