[AMD Official Use Only - General]
Thanks for the fix. Yes, the support for APUs was missing from the relevant
code.
I think you can just drop the piece of code below.
/////////////
else {
dev_warn(smu->adev->dev, "Unexpected and unhandled
version: %d.%d\n",
(uint32_t)frev, (uint32_t)crev);
}
/////////////
Either-way the patch is reviewed-by: Evan Quan <[email protected]>
BR
Evan
> -----Original Message-----
> From: Alex Deucher <[email protected]>
> Sent: Thursday, June 16, 2022 11:12 AM
> To: Limonciello, Mario <[email protected]>; Quan, Evan
> <[email protected]>; Feng, Kenneth <[email protected]>
> Cc: amd-gfx list <[email protected]>
> Subject: Re: [PATCH] drm/amd: Don't show warning on reading vbios values
> for SMU13 3.1
>
> On Tue, Jun 14, 2022 at 10:22 AM Mario Limonciello
> <[email protected]> wrote:
> >
> > Some APUs with SMU13 are showing the following message:
> > `amdgpu 0000:63:00.0: amdgpu: Unexpected and unhandled version: 3.1`
> >
> > This warning isn't relevant for smu info 3.1, as no bootup information
> > is present in the table.
> >
> > Fixes: 6a73454350c0 ("drm/amd/pm: correct the way for retrieving
> > bootup clocks")
> > Signed-off-by: Mario Limonciello <[email protected]>
> > ---
> > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > index f18f9605e586..0e59ab2192bf 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> > @@ -731,6 +731,8 @@ int smu_v13_0_get_vbios_bootup_values(struct
> smu_context *smu)
> > smu->smu_table.boot_values.vclk = smu_info_v3_6-
> >bootup_vclk_10khz;
> > smu->smu_table.boot_values.dclk = smu_info_v3_6-
> >bootup_dclk_10khz;
> > smu->smu_table.boot_values.fclk =
> > smu_info_v3_6->bootup_fclk_10khz;
> > + } else if ((frev == 3) && (crev == 1)) {
> > + return 0;
>
> I don't know if Evan has any comments, but it might be better to just return
> if
> ((frev == 3) && (crev < 2)). I'm not sure off hand which smu_info table
> versions we might run into. Evan or Kenneth would know which smu_info
> table versions are valid on which SMU 13.x asics.
>
> A;ex
>
>
> > } else if ((frev == 4) && (crev == 0)) {
> > smu_info_v4_0 = (struct atom_smu_info_v4_0
> > *)header;
> >
> > --
> > 2.25.1
> >
