[AMD Official Use Only] Hit send too quickly. With below addressed, the patch is
Reviewed-by: Hawking Zhang <[email protected]> Regards, Hawking -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Zhang, Hawking Sent: Wednesday, March 16, 2022 21:49 To: Zhou1, Tao <[email protected]>; [email protected]; Kuehling, Felix <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas <[email protected]> Subject: RE: [PATCH 1/4] drm/amdkfd: refine event_interrupt_poison_consumption [AMD Official Use Only] [AMD Official Use Only] + pr_warn("RAS poison consumption handling\n"); Given you already print out this, might be better add some more information to help identify which blocks issued this poison consumption interrupt. e.g. add client_id or source_id Regards, Hawking -----Original Message----- From: Zhou1, Tao <[email protected]> Sent: Wednesday, March 16, 2022 17:26 To: [email protected]; Zhang, Hawking <[email protected]>; Kuehling, Felix <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas <[email protected]> Cc: Zhou1, Tao <[email protected]> Subject: [PATCH 1/4] drm/amdkfd: refine event_interrupt_poison_consumption Combine reading and setting poison flag as one atomic operation and add print message for the function. Signed-off-by: Tao Zhou <[email protected]> --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c index 7eedbcd14828..a992798ff8b6 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c @@ -93,20 +93,19 @@ enum SQ_INTERRUPT_ERROR_TYPE { static void event_interrupt_poison_consumption(struct kfd_dev *dev, uint16_t pasid, uint16_t source_id) { - int ret = -EINVAL; + int old_poison, ret = -EINVAL; struct kfd_process *p = kfd_lookup_process_by_pasid(pasid); if (!p) return; /* all queues of a process will be unmapped in one time */ - if (atomic_read(&p->poison)) { - kfd_unref_process(p); + old_poison = atomic_cmpxchg(&p->poison, 0, 1); + kfd_unref_process(p); + if (old_poison) return; - } - atomic_set(&p->poison, 1); - kfd_unref_process(p); + pr_warn("RAS poison consumption handling\n"); switch (source_id) { case SOC15_INTSRC_SQ_INTERRUPT_MSG: -- 2.35.1
