Dear Lang,

Am 12.10.21 um 08:16 schrieb Lang Yu:
Display support for cyan skillfish is ready now.

What is the last commit making it “ready”?

Enable it!

How did you test the patch?

Signed-off-by: Lang Yu <[email protected]>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 2bebd2ce6474..4228c7964175 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -736,6 +736,7 @@ static int amdgpu_discovery_set_display_ip_blocks(struct 
amdgpu_device *adev)
                case IP_VERSION(1, 0, 1):
                case IP_VERSION(2, 0, 2):
                case IP_VERSION(2, 0, 0):
+               case IP_VERSION(2, 0, 3):

The numbers are not ordered. Could you please put a patch before this one, fixing the ordering?

                case IP_VERSION(2, 1, 0):
                case IP_VERSION(3, 0, 0):
                case IP_VERSION(3, 0, 2):
@@ -745,8 +746,6 @@ static int amdgpu_discovery_set_display_ip_blocks(struct 
amdgpu_device *adev)
                case IP_VERSION(3, 1, 3):
                        amdgpu_device_ip_block_add(adev, &dm_ip_block);
                        break;
-               case IP_VERSION(2, 0, 3):
-                       break;
                default:
                        return -EINVAL;
                }



Kind regards,

Paul

Reply via email to