[AMD Official Use Only] Yes, the information is from MMSCH firmware team. They are saying the version info is not used in the old MMSCH firmware, so it won't break the ASICs using old MMSCH firmware. Ok, I will change the commit message to specify mmsch 1.0.
Thanks, Zhigang -----Original Message----- From: Liu, Shaoyun <[email protected]> Sent: August 16, 2021 10:49 AM To: Luo, Zhigang <[email protected]>; [email protected] Subject: RE: [PATCH] drm/amdgpu: correct MMSCH version [AMD Official Use Only] Is that information from MM team ? Please make sure it won't break the ASICs that use the same code path. Also If this is true for all mmsch_v1.0 , you need to specify this is mmSCH v1.0 , since other MMSCH version will still use this major and minor. Shaoyun.liu -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Zhigang Luo Sent: Thursday, August 12, 2021 11:07 AM To: [email protected] Cc: Luo, Zhigang <[email protected]> Subject: [PATCH] drm/amdgpu: correct MMSCH version MMSCH doesn't have major/minor version, only verison. Signed-off-by: Zhigang Luo <[email protected]> --- drivers/gpu/drm/amd/amdgpu/mmsch_v1_0.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmsch_v1_0.h b/drivers/gpu/drm/amd/amdgpu/mmsch_v1_0.h index 20958639b601..2cdab8062c86 100644 --- a/drivers/gpu/drm/amd/amdgpu/mmsch_v1_0.h +++ b/drivers/gpu/drm/amd/amdgpu/mmsch_v1_0.h @@ -24,9 +24,7 @@ #ifndef __MMSCH_V1_0_H__ #define __MMSCH_V1_0_H__ -#define MMSCH_VERSION_MAJOR 1 -#define MMSCH_VERSION_MINOR 0 -#define MMSCH_VERSION (MMSCH_VERSION_MAJOR << 16 | MMSCH_VERSION_MINOR) +#define MMSCH_VERSION 0x1 enum mmsch_v1_0_command_type { MMSCH_COMMAND__DIRECT_REG_WRITE = 0, -- 2.17.1
