[Public] Hello Guchun,
In most of those cases you are right it is redundant, the reason i kept them separate for now is to resolve this bug while also keeping those interfaces modular, and not affecting the psp submit sequence yet. We are planning a bigger change to that source to remove alot of the duplicate code regarding the cmd buffer prepare/submit flow and will probably go back down to one mutex there. Thank you, John Clements ________________________________ From: Chen, Guchun <[email protected]> Sent: Tuesday, August 3, 2021 9:58 PM To: Clements, John <[email protected]>; [email protected] <[email protected]> Cc: Zhang, Hawking <[email protected]>; Li, Candice <[email protected]>; Lazar, Lijo <[email protected]> Subject: RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access [Public] Before calling into psp_cmd_submit_buf, a mutex psp->cmd_buf_mutex is there, and after entering psp_cmd_submit_buf, there is another mutex psp->mutex, is it a bit redundant? Regards, Guchun From: Clements, John <[email protected]> Sent: Tuesday, August 3, 2021 5:50 PM To: [email protected] Cc: Zhang, Hawking <[email protected]>; Li, Candice <[email protected]>; Lazar, Lijo <[email protected]>; Chen, Guchun <[email protected]> Subject: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access [AMD Official Use Only] Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions.
