[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan <[email protected]>
-----Original Message----- From: Alex Deucher <[email protected]> Sent: Thursday, February 25, 2021 4:27 PM To: Kim, Jonathan <[email protected]> Cc: amd-gfx list <[email protected]>; Kasiviswanathan, Harish <[email protected]> Subject: Re: [PATCH] drm/amdgpu: add missing df counter disable write On Tue, Feb 23, 2021 at 4:34 PM Jonathan Kim <[email protected]> wrote: > > Request to stop DF performance counters is missing the actual write to the > controller register. > > Reported-by: Chris Freehill <[email protected]> > Signed-off-by: Jonathan Kim <[email protected]> Acked-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c > b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c > index 6b4b30a8dce5..44109a6b8f44 100644 > --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c > +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c > @@ -568,6 +568,8 @@ static int df_v3_6_pmc_stop(struct amdgpu_device *adev, > uint64_t config, > if (ret) > return ret; > > + df_v3_6_perfmon_wreg(adev, lo_base_addr, lo_val, > + hi_base_addr, hi_val); > > if (is_remove) { > df_v3_6_reset_perfmon_cntr(adev, config, counter_idx); > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > [email protected] > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CHarish.Kasiviswanathan%40amd.com%7Cb6226ef6319b42b8211008d8d9d41a5d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637498852287647783%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VEuHTYnsJLYbTSmMhu7NEWUaLndUfOh8XKiqJy1%2Fjyk%3D&reserved=0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
