Just curious, but I noticed this new lock manager isn't being used because of the definitive false return value in display/dc/dce/dmub_hw_lock_mgr.c: should_use_dmub_lock. Was this supposed to be enabled?
From: Wyatt Wood <[email protected]> > > [Why] > Feature requires synchronization of dig, pipe, and cursor locking > between driver and fw. > > [How] > Set flag to force psr to use hw lock mgr. > > Signed-off-by: Wyatt Wood <[email protected]> > Reviewed-by: Anthony Koo <[email protected]> > Acked-by: Eryk Brol <[email protected]> > --- > drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > index 82e67bd81f2d..5167d6b8a48d 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > @@ -233,8 +233,8 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub, > copy_settings_data->frame_cap_ind = > psr_context->psrFrameCaptureIndicationReq; > copy_settings_data->debug.bitfields.visual_confirm = > dc->dc->debug.visual_confirm == VISUAL_CONFIRM_PSR ? > true : > false; > + copy_settings_data->debug.bitfields.use_hw_lock_mgr = 1; > copy_settings_data->init_sdp_deadline = > psr_context->sdpTransmitLineNumDeadline; > - copy_settings_data->debug.bitfields.use_hw_lock_mgr = 0; > > dc_dmub_srv_cmd_queue(dc->dmub_srv, &cmd); > dc_dmub_srv_cmd_execute(dc->dmub_srv); > -- > 2.25.1 > >
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
