[AMD Public Use] Exactly Tao. When hw_support capability is aligned with AMDGPU_RAS_BLOCK_MASK by and operation, sw_support capability is calculated on top of hw_support value and amdgpu_ras_mask accordingly.
Regards, Guchun -----Original Message----- From: Zhou1, Tao <[email protected]> Sent: Tuesday, June 2, 2020 2:12 PM To: Chen, Guchun <[email protected]>; [email protected]; Zhang, Hawking <[email protected]>; Li, Dennis <[email protected]>; Clements, John <[email protected]> Subject: RE: [PATCH] drm/amdgpu: remove RAS's useless code [AMD Public Use] I think the real reason is we have " *hw_supported &= AMDGPU_RAS_BLOCK_MASK;" already, but the patch is: Reviewed-by: Tao Zhou <[email protected]> > -----Original Message----- > From: Chen, Guchun <[email protected]> > Sent: 2020年6月2日 13:58 > To: [email protected]; Zhang, Hawking > <[email protected]>; Zhou1, Tao <[email protected]>; Li, Dennis > <[email protected]>; Clements, John <[email protected]> > Cc: Chen, Guchun <[email protected]> > Subject: [PATCH] drm/amdgpu: remove RAS's useless code > > Module parameter amdgpu_ras_mask has been involved in the calculation > of ras support capability, so drop this redundant code. > > Signed-off-by: Guchun Chen <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index 79bb05d791bc..337bf2da7bdc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -1902,8 +1902,6 @@ int amdgpu_ras_init(struct amdgpu_device *adev) > goto err_out; > } > > - amdgpu_ras_mask &= AMDGPU_RAS_BLOCK_MASK; > - > if (amdgpu_ras_fs_init(adev)) { > r = -EINVAL; > goto err_out; > -- > 2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
