[AMD Official Use Only - Internal Distribution Only] Hi Alex,
the flag of "ATTR_STATE_[UN]SUPPORTED" should be binding to device not device attribute node, when inserting two different video cards, the driver may be need to create different node according device type (vega, navi,...), and when unload driver, the driver also need remove different node according device type and the state of ATTR_STATE_SUPPORTED. so i think the ATTR_STATE_XXX is not work well on multi gpu, so we'd better revert previous patch. thanks. Best Regards, Kevin ________________________________ From: amd-gfx <[email protected]> on behalf of Quan, Evan <[email protected]> Sent: Friday, May 22, 2020 1:35 PM To: Alex Deucher <[email protected]>; [email protected] <[email protected]> Cc: Deucher, Alexander <[email protected]> Subject: RE: [PATCH] drm/amdgpu: fix sysfs power controls with multi-GPU [AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Acked-by: Evan Quan <[email protected]> -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Alex Deucher Sent: Friday, May 22, 2020 5:38 AM To: [email protected] Cc: Deucher, Alexander <[email protected]> Subject: [PATCH] drm/amdgpu: fix sysfs power controls with multi-GPU Reset the SUPPORTED attribute. Signed-off-by: Alex Deucher <[email protected]> --- This fixes multi-GPU, but I think we could still race without some sort of locking around the attr array. drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index e06fef6174e5..4c65444e9ef7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c @@ -1790,6 +1790,8 @@ static int amdgpu_device_attr_create(struct amdgpu_device *adev, BUG_ON(!attr); +attr->states = ATTR_STATE_SUPPORTED; + attr_update = attr->attr_update ? attr_update : default_attr_update; ret = attr_update(adev, attr, mask); -- 2.25.4 _______________________________________________ amd-gfx mailing list [email protected] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cd86afa6ac5ab49bd75d208d7fe11ed8d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637257225315854026&sdata=TMiKBdpSF4wPgkLgbRBtTloPLFBHyyLXuO%2BxSgSE%2BeY%3D&reserved=0 _______________________________________________ amd-gfx mailing list [email protected] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CKevin1.Wang%40amd.com%7Cd86afa6ac5ab49bd75d208d7fe11ed8d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637257225315864023&sdata=MtypjxOmgqJhKwNEMH75r3Z%2F9M3Uv7qTpOjQo1yBSVk%3D&reserved=0
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
