[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily Deng <[email protected]>
>-----Original Message----- >From: amd-gfx <[email protected]> On Behalf Of Gu, >JiaWei (Will) >Sent: Tuesday, April 21, 2020 11:56 AM >To: Gu, JiaWei (Will) <[email protected]>; [email protected] >Subject: RE: [PATCH] SWDEV-231280 CentOS-AWS Guest driver reload 3 failed >with call trace in guest > >[AMD Official Use Only - Internal Distribution Only] > >Ping...... > >-----Original Message----- >From: Jiawei <[email protected]> >Sent: Monday, April 20, 2020 7:34 PM >To: [email protected] >Cc: Gu, JiaWei (Will) <[email protected]> >Subject: [PATCH] SWDEV-231280 CentOS-AWS Guest driver reload 3 failed >with call trace in guest > >root cause: >X enables vblank, but driver skips shutting down vblank during unloading >under sriov, which causes kernel call trace > >solution: >move vblank shutdown logic into dce_virtual_crtc_disable() to avoid sriov skip > >Signed-off-by: Jiawei <[email protected]> >--- > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c >b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c >index 3f739efead61..c02797f2ee7f 100644 >--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c >+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c >@@ -191,8 +191,9 @@ static void dce_virtual_crtc_disable(struct drm_crtc >*crtc) { > struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc); > >- dce_virtual_crtc_dpms(crtc, DRM_MODE_DPMS_OFF); >+ drm_crtc_vblank_off(crtc); > >+ amdgpu_crtc->enabled = false; > amdgpu_crtc->pll_id = ATOM_PPLL_INVALID; > amdgpu_crtc->encoder = NULL; > amdgpu_crtc->connector = NULL; >-- >2.20.1 >_______________________________________________ >amd-gfx mailing list >[email protected] >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fr >eedesktop.org%2Fmailman%2Flistinfo%2Famd- >gfx&data=02%7C01%7CEmily.Deng%40amd.com%7C326cebfffbdd4ceb79 >af08d7e5a7dc4d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63 >7230382202343716&sdata=pEeq7kwcCppKlc598GGsG4ES5bhRONDT9rw >bBwfjuGI%3D&reserved=0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
