Looks fine to me as well. Just as Christian said, would have to be approved by Marek.
Regards, Luben On 2020-02-11 9:57 a.m., Deucher, Alexander wrote: > Yes, correct. > > Alex > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *From:* Huang, Ray <[email protected]> > *Sent:* Tuesday, February 11, 2020 9:35 AM > *To:* Deucher, Alexander <[email protected]>; Christian König > <[email protected]>; [email protected] > <[email protected]> > *Cc:* Pelloux-prayer, Pierre-eric <[email protected]>; > Olsak, Marek <[email protected]>; Liu, Aaron <[email protected]>; Tuikov, > Luben <[email protected]>; Koenig, Christian <[email protected]> > *Subject:* RE: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for > amdgpu tests > > > [AMD Public Use] > > > > Hi Alex, > > > > MR = merge request? Should I create account to send merge request in the > freedesktop gitlab? > > > > Thanks, > > Ray > > > > *From:* Deucher, Alexander <[email protected]> > *Sent:* Tuesday, February 11, 2020 10:30 PM > *To:* Christian König <[email protected]>; Huang, Ray > <[email protected]>; [email protected] > *Cc:* Pelloux-prayer, Pierre-eric <[email protected]>; > Olsak, Marek <[email protected]>; Liu, Aaron <[email protected]>; Tuikov, > Luben <[email protected]>; Koenig, Christian <[email protected]> > *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for > amdgpu tests > > > > [AMD Public Use] > > > > Also, libdrm changes should go through a gitlab MR now. > > > > Alex > > > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > *From:*Christian König <[email protected] > <mailto:[email protected]>> > *Sent:* Tuesday, February 11, 2020 6:39 AM > *To:* Huang, Ray <[email protected] <mailto:[email protected]>>; > [email protected] > <mailto:[email protected]><[email protected] > <mailto:[email protected]>> > *Cc:* Pelloux-prayer, Pierre-eric <[email protected] > <mailto:[email protected]>>; Olsak, Marek > <[email protected] <mailto:[email protected]>>; Liu, Aaron > <[email protected] <mailto:[email protected]>>; Tuikov, Luben > <[email protected] <mailto:[email protected]>>; Deucher, Alexander > <[email protected] <mailto:[email protected]>>; Koenig, > Christian <[email protected] <mailto:[email protected]>> > *Subject:* Re: [PATCH libdrm 0/4] amdgpu: use amdgpu_cs_submit_raw2 for > amdgpu tests > > > > Looks good on first glance, but Marek and/or Pierre can probably better > judge than me. > > Christian. > > Am 11.02.20 um 12:22 schrieb Huang Rui: >> So far, the amdgpu_cs_submit_raw2 is used for MesaGL, however the amdgpu >> tests >> still use the legacy interface. So we would like to make amdgpu tests verify >> the >> amdgpu_cs_submit_raw2 API. >> >> Thanks, >> Ray >> >> Huang Rui (4): >> amdgpu: use alloca for dependencies and sem_dependencies >> amdgpu: use amdgpu_cs_submit_raw2 in amdgpu_cs_submit >> amdgpu: remove the un-used chunk_array >> amdgpu: clean up the cs structure variable >> >> amdgpu/amdgpu_cs.c | 36 +++++++++++++----------------------- >> 1 file changed, 13 insertions(+), 23 deletions(-) >> > _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
