Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on.
Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie ________________________________ From: Deucher, Alexander <[email protected]> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie <[email protected]>; [email protected] <[email protected]> Cc: Xiao, Jack <[email protected]>; Wang, Kevin(Yang) <[email protected]>; Zhang, Hawking <[email protected]>; Quan, Evan <[email protected]>; Feng, Kenneth <[email protected]> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex ________________________________ From: amd-gfx <[email protected]> on behalf of Yuan, Xiaojie <[email protected]> Sent: Wednesday, October 9, 2019 7:08 AM To: [email protected] <[email protected]> Cc: Xiao, Jack <[email protected]>; Wang, Kevin(Yang) <[email protected]>; Zhang, Hawking <[email protected]>; Quan, Evan <[email protected]>; Feng, Kenneth <[email protected]>; Yuan, Xiaojie <[email protected]> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan <[email protected]> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
