Stop, wait a second guys!

This will disable the workaround for Navi10 and that is certainly not correct:
!(adev->asic_type >= CHIP_NAVI10 && adev->asic_type <= CHIP_NAVI12)

Christian.


Am 26.09.19 um 14:26 schrieb Deucher, Alexander:
Please add a patch description.  With that fixed:
Reviewed-by: Alex Deucher <[email protected]>
------------------------------------------------------------------------
*From:* amd-gfx <[email protected]> on behalf of Yuan, Xiaojie <[email protected]>
*Sent:* Thursday, September 26, 2019 4:09 AM
*To:* [email protected] <[email protected]>
*Cc:* [email protected] <[email protected]>
*Subject:* Re: [PATCH] drm/amdgpu/gmc10: apply the 'invalidation from sdma' workaround for navi
Hi Alex,

This patch is to add the asic_type check which is missing after drm-next branch rebase.

BR,
Xiaojie
------------------------------------------------------------------------
*From:* Yuan, Xiaojie <[email protected]>
*Sent:* Thursday, September 26, 2019 4:08 PM
*To:* [email protected] <[email protected]>
*Cc:* [email protected] <[email protected]>; Yuan, Xiaojie <[email protected]> *Subject:* [PATCH] drm/amdgpu/gmc10: apply the 'invalidation from sdma' workaround for navi Fixes: 767acabdac81 ("drm/amd/powerplay: add baco smu reset function for smu11")
Signed-off-by: Xiaojie Yuan <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
index cb3f61873baa..dc2e68e019eb 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
@@ -292,6 +292,7 @@ static void gmc_v10_0_flush_gpu_tlb(struct amdgpu_device *adev, uint32_t vmid,

         if (!adev->mman.buffer_funcs_enabled ||
             !adev->ib_pool_ready ||
+           !(adev->asic_type >= CHIP_NAVI10 && adev->asic_type <= CHIP_NAVI12) ||
             adev->in_gpu_reset) {
                 gmc_v10_0_flush_vm_hub(adev, vmid, AMDGPU_GFXHUB_0, 0);
mutex_unlock(&adev->mman.gtt_window_lock);
--
2.20.1


_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to