With the following addressed, the patch is reviewed-by: Evan Quan <[email protected]>
-----Original Message----- From: Liang, Prike <[email protected]> Sent: Thursday, September 26, 2019 11:50 AM To: [email protected] Cc: Quan, Evan <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Liang, Prike <[email protected]> Subject: [PATCH 6/8] drm/amd/powerplay: implement interface set_power_profile_mode() Add set_power_profile_mode() for none manual dpm level case setting power profile mode. Signed-off-by: Prike Liang <[email protected]> --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c index 4f2b750..151d78e 100644 --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c @@ -482,6 +482,35 @@ static int renoir_force_clk_levels(struct smu_context *smu, return ret; } +static int renoir_set_power_profile_mode(struct smu_context *smu, long +*input, uint32_t size) { + int workload_type, ret; + + smu->power_profile_mode = input[size]; + [Quan, Evan] move this to place B. That's to update current profile mode only when it's valid. + if (smu->power_profile_mode > PP_SMC_POWER_PROFILE_CUSTOM) { + pr_err("Invalid power profile mode %d\n", smu->power_profile_mode); + return -EINVAL; + } + [Quan, Evan] place B + /* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */ + workload_type = smu_workload_get_type(smu, smu->power_profile_mode); + if (workload_type < 0) { + pr_err("Unsupported power profile mode %d on RENOIR\n",smu->power_profile_mode); + return -EINVAL; + } + + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetWorkloadMask, + 1 << workload_type); + if (ret) { + pr_err("Fail to set workload type %d\n", workload_type); + return ret; + } + + return 0; +} + + static const struct pptable_funcs renoir_ppt_funcs = { .get_smu_msg_index = renoir_get_smu_msg_index, .get_smu_table_index = renoir_get_smu_table_index, @@ -496,6 +525,7 @@ static const struct pptable_funcs renoir_ppt_funcs = { .get_workload_type = renoir_get_workload_type, .get_profiling_clk_mask = renoir_get_profiling_clk_mask, .force_clk_levels = renoir_force_clk_levels, + .set_power_profile_mode = renoir_set_power_profile_mode, }; void renoir_set_ppt_funcs(struct smu_context *smu) -- 2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
