Maybe add a comment here in the code to avoid confusion in the future. Alex ________________________________ From: Koenig, Christian <[email protected]> Sent: Saturday, September 21, 2019 7:32 AM To: Navid Emamdoost <[email protected]> Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Deucher, Alexander <[email protected]>; Zhou, David(ChunMing) <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Sam Ravnborg <[email protected]>; Rex Zhu <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Subject: Re: [PATCH] drm/amdgpu: release allocated memory
Am 21.09.19 um 00:49 schrieb Navid Emamdoost: > In amdgpu_vmid_grab_idle, fences is being leaked in one execution path. > The missing kfree was added. NAK, the array is freed by the dma_fence_array. This is a double free. Regards, Christian. > > Signed-off-by: Navid Emamdoost <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > index 57b3d8a9bef3..9063cd36fa94 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -244,6 +244,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm, > r = amdgpu_sync_fence(adev, sync, &array->base, false); > dma_fence_put(ring->vmid_wait); > ring->vmid_wait = &array->base; > + kfree(fences); > return r; > } > kfree(fences);
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
