Hi Michel, My bad. Sorry for that. My solution is to take the first suggestion from you, will prepare one patch soon for this.
Regards, Guchun -----Original Message----- From: Michel Dänzer <[email protected]> Sent: Friday, August 9, 2019 10:13 PM To: Chen, Guchun <[email protected]>; Alex Deucher <[email protected]> Cc: Zhou1, Tao <[email protected]>; [email protected]; Deucher, Alexander <[email protected]>; Li, Candice <[email protected]>; Li, Dennis <[email protected]>; Zhang, Hawking <[email protected]> Subject: Re: libdrm patch merge request This broke the CI pipeline: https://gitlab.freedesktop.org/mesa/drm/pipelines/54903 Looks like the problem is that the autotools build doesn't properly disable the amdgpu tests when the json-c library is missing. I suggest the following: 1. Add a HAVE_JSONC guard in tests/Makefile.am 2. Add libjson-c-dev to the packages installed by the oldest-autotools job in .gitlab-ci.yml Until libdrm uses GitLab merge requests to catch this kind of issue before it hits master, please push changes to a branch in a forked personal repository and make sure the CI pipeline comes back green before asking for them to be pushed to master. Thanks, On 2019-08-09 3:25 a.m., Chen, Guchun wrote: > Thanks, Alex. > > Regards, > Guchun > > -----Original Message----- > From: Alex Deucher <[email protected]> > Sent: Friday, August 9, 2019 1:24 AM > To: Chen, Guchun <[email protected]> > Cc: Deucher, Alexander <[email protected]>; > [email protected]; Zhou1, Tao <[email protected]>; Li, > Candice <[email protected]>; Li, Dennis <[email protected]>; Zhang, > Hawking <[email protected]> > Subject: Re: libdrm patch merge request > > Done! > > Alex > > On Thu, Aug 8, 2019 at 5:18 AM Chen, Guchun <[email protected]> wrote: >> >> Hi Alex, >> >> >> >> Would you mind merging attached 3 patches to libdrm master branch? >> >> These changes are implemented for gfx and umc ras inject unit test by >> amdgpu_test. >> >> Thanks a lot. >> >> >> >> Regards, >> >> Guchun >> >> >> >> _______________________________________________ >> amd-gfx mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
