This was to avoid extra code in amdgpu_cs_parser_bos when amdgpu_bo_list_get is called. But I see your argument about random id guess (practically unrealistic to happen but still a valid argument). I will do some minor alterations to avoid this and respin the patch.

Andrey


On 07/11/2018 11:42 AM, Christian König wrote:
Why is the bo_list on the idr in the first place?

That sounds like it is unnecessary and maybe even quite dangerous when somebody guesses the temporary allocated id and messes it from another CPU at the same time while the CS IOCTL is processing things.

Christian.

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to