Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s Why change the logic in kmd side ?
I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user Still want those message printed out Can you do this way ? In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ? /Monk From: amd-gfx [mailto:[email protected]] On Behalf Of Quan, Evan Sent: 2018年3月19日 9:47 To: Deucher, Alexander <[email protected]>; Michel Dänzer <[email protected]> Cc: [email protected] Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues That’s fine for me. Will update the patch accordingly. Regards, Evan From: Deucher, Alexander Sent: Saturday, March 17, 2018 1:17 AM To: Michel Dänzer <[email protected]<mailto:[email protected]>>; Quan, Evan <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues How about something like this: /* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */ If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1) amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT; Alex ________________________________ From: Michel Dänzer <[email protected]<mailto:[email protected]>> Sent: Friday, March 16, 2018 12:25:03 PM To: Deucher, Alexander; Quan, Evan Cc: [email protected]<mailto:[email protected]> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues On 2018-03-16 05:14 PM, Deucher, Alexander wrote: > Since GPU reset is not enabled yet anyway, a timeout will just print a > message, can we just change amdgpu_lockup_timeout to > MAX_SCHEDULE_TIMEOUT until we enable GPU reset? Wouldn't that be rather surprising for somebody who sets amdgpu.gpu_recovery=1 ? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
