Reviewed-by: Rex Zhu <[email protected]>
Best Regards Rex ________________________________ From: amd-gfx <[email protected]> on behalf of Quan, Evan <[email protected]> Sent: Wednesday, March 14, 2018 11:20 AM To: Alex Deucher; [email protected] Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path Reviewed-by: Evan Quan <[email protected]> -----Original Message----- From: amd-gfx [mailto:[email protected]] On Behalf Of Alex Deucher Sent: Wednesday, March 14, 2018 9:46 AM To: [email protected] Cc: Deucher, Alexander <[email protected]> Subject: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path Free the backend structure if we fail to allocate device memory. Signed-off-by: Alex Deucher <[email protected]> --- drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c index 15e1afa28018..219950882be9 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c @@ -406,9 +406,8 @@ static int vega10_smu_init(struct pp_hwmgr *hwmgr) &handle, &mc_addr, &kaddr); - if (ret) - return -EINVAL; + goto free_backend; priv->smu_tables.entry[PPTABLE].version = 0x01; priv->smu_tables.entry[PPTABLE].size = sizeof(PPTable_t); @@ -511,6 +510,9 @@ static int vega10_smu_init(struct pp_hwmgr *hwmgr) amdgpu_bo_free_kernel(&priv->smu_tables.entry[PPTABLE].handle, &priv->smu_tables.entry[PPTABLE].mc_addr, &priv->smu_tables.entry[PPTABLE].table); +free_backend: + kfree(hwmgr->smu_backend); + return -EINVAL; } -- 2.13.6 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx> lists.freedesktop.org Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of ... _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx> lists.freedesktop.org Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of ...
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
