On 2017-11-07 03:18 PM, Ernst Sjöstrand wrote: > Reported by smartch: > amdgpu_dm_commit_planes() error: double unlock > 'spin_lock:&crtc->dev->event_lock' > amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags' > > The error path doesn't return so we only need a single unlock. > > Signed-off-by: Ernst Sjöstrand <[email protected]>
Reviewed-by: Harry Wentland <[email protected]> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 2ba5d9bddd6f..86c39fc68b2f 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -3928,7 +3928,6 @@ static void amdgpu_dm_commit_planes(struct > drm_atomic_state *state, > DRM_ERROR("%s: acrtc %d, already busy\n", > __func__, > acrtc_attach->crtc_id); > - spin_unlock_irqrestore(&crtc->dev->event_lock, flags); > /* In commit tail framework this cannot happen */ > WARN_ON(1); > } > _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
