Since commit 3756310e9fe1 ("drm/ttm: Use the LRU walker for eviction"),
ttm_mem_evict_first has been removed and ttm_bo_evict_first does not
call eviction_valuable.Remove the list of callers from the comment, since that is prone to be outdated. While at it, document the function parameters. Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 16c060badaee..1e44be64f38d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c @@ -1477,10 +1477,10 @@ uint64_t amdgpu_ttm_tt_pte_flags(struct amdgpu_device *adev, struct ttm_tt *ttm, * amdgpu_ttm_bo_eviction_valuable - Check to see if we can evict a buffer * object. * - * Return true if eviction is sensible. Called by ttm_mem_evict_first() on - * behalf of ttm_bo_mem_force_space() which tries to evict buffer objects until - * it can find space for a new object and by ttm_bo_force_list_clean() which is - * used to clean out a memory space. + * @bo: The buffer object to evict + * @place: the placement we need to make room for + * + * Return true if eviction is sensible. */ static bool amdgpu_ttm_bo_eviction_valuable(struct ttm_buffer_object *bo, const struct ttm_place *place) --- base-commit: 903f8773ee96c5dc5fb9aec65227f39fd3e7a1dc change-id: 20260703-amdgpu-ttm_mem_evict_first_comment-8601e6479407 Best regards, -- Thadeu Lima de Souza Cascardo <[email protected]>
