On 7/1/26 18:17, Timur Kristóf wrote: > When there are a lot of retry faults happening, the soft IH ring > can fill up really quickly and possibly overflow. PAGE_SIZE was > too small, use IH_SW_RING_SIZE to match what other GPU generations > are doing. > > Signed-off-by: Timur Kristóf <[email protected]> > Reviewed-by: Tvrtko Ursulin <[email protected]>
Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c > b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c > index 24be9d726428..f1de6450a31d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c > @@ -601,7 +601,6 @@ static int ih_v7_0_sw_init(struct amdgpu_ip_block > *ip_block) > int r; > struct amdgpu_device *adev = ip_block->adev; > bool use_bus_addr; > - unsigned int sw_ring_size; > > r = amdgpu_irq_add_id(adev, SOC21_IH_CLIENTID_IH, 0, > &adev->irq.self_irq); > @@ -633,9 +632,7 @@ static int ih_v7_0_sw_init(struct amdgpu_ip_block > *ip_block) > /* initialize ih control register offset */ > ih_v7_0_init_register_offset(adev); > > - sw_ring_size = (amdgpu_ip_version(adev, OSSSYS_HWIP, 0) == > IP_VERSION(7, 1, 0)) ? > - IH_SW_RING_SIZE : PAGE_SIZE; > - r = amdgpu_ih_ring_init(adev, &adev->irq.ih_soft, sw_ring_size, true); > + r = amdgpu_ih_ring_init(adev, &adev->irq.ih_soft, IH_SW_RING_SIZE, > true); > if (r) > return r; >
