> -----Original Message----- > From: amd-gfx [mailto:[email protected]] On Behalf > Of Christian König > Sent: Thursday, October 26, 2017 12:06 PM > To: [email protected] > Subject: [PATCH 2/8] drm/amdgpu: always bind pinned BOs > > From: Christian König <[email protected]> > > We always need to bind pinned BOs, not just when the caller requested the > address. > > Signed-off-by: Christian König <[email protected]>
Reviewed-by: Alex Deucher <[email protected]> Should this go to stable as well? Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index 76551cd..0b76d83 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -688,15 +688,15 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo > *bo, u32 domain, > goto error; > } > > + r = amdgpu_ttm_bind(&bo->tbo, &bo->tbo.mem); > + if (unlikely(r)) { > + dev_err(adev->dev, "%p bind failed\n", bo); > + goto error; > + } > + > bo->pin_count = 1; > - if (gpu_addr != NULL) { > - r = amdgpu_ttm_bind(&bo->tbo, &bo->tbo.mem); > - if (unlikely(r)) { > - dev_err(adev->dev, "%p bind failed\n", bo); > - goto error; > - } > + if (gpu_addr != NULL) > *gpu_addr = amdgpu_bo_gpu_offset(bo); > - } > > domain = amdgpu_mem_type_to_domain(bo- > >tbo.mem.mem_type); > if (domain == AMDGPU_GEM_DOMAIN_VRAM) { > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
