This needs a fixes tag. One comment below. With these both addressed, this patch is Reviewed-by: Harish Kasiviswanathan <[email protected]>
________________________________________ From: amd-gfx <[email protected]> on behalf of Eric Huang <[email protected]> Sent: Wednesday, November 19, 2025 4:13 PM To: [email protected] <[email protected]> Cc: Huang, JinHuiEric <[email protected]> Subject: [PATCH] drm/amdkfd: assign AID to uuid in topology for SPX mode XCD id is assigned to uuid, which causes some performance drop in SPX mode, assigning AID back will resolve the issue. Signed-off-by: Eric Huang <[email protected]> --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index 5c98746eb72d..525e70e45353 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c @@ -530,7 +530,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr, sysfs_show_32bit_prop(buffer, offs, "sdma_fw_version", dev->gpu->kfd->sdma_fw_version); sysfs_show_64bit_prop(buffer, offs, "unique_id", - dev->gpu->xcp ? + dev->gpu->xcp && dev->gpu->xcp->xcp_mgr->mode ? [HK]: It is safer to (dev->gpu->xcp->xcp_mgr->mode == AMDGPU_SPX_PARTITION_MODE). Otherwise, it hinges on AMDGPU_SPX_PARTITION_MODE being 0 dev->gpu->xcp->unique_id : dev->gpu->adev->unique_id); sysfs_show_32bit_prop(buffer, offs, "num_xcc", -- 2.34.1
