On Fri, Aug 1, 2025 at 3:48 AM Jesse.Zhang <[email protected]> wrote:
>
> This commit fixes a firmware version check for enabling user queue
> support in SDMA v7.0. The previous version check (7836028) was
> incorrect and could lead to issues with PROTECTED_FENCE_SIGNAL
> commands causing register conflicts between MCU_DBG0 and MCU_DBG1.
>
> Signed-off-by: Jesse Zhang <[email protected]>
Please add:
Fixes: 71f82efdc1ad ("drm/amdgpu/sdma7: add ucode version checks for
userq support")
With that,
Reviewed-by: Alex Deucher <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
> index ba1f3e3b6eb6..d50db12a44a5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c
> @@ -1357,7 +1357,7 @@ static int sdma_v7_0_sw_init(struct amdgpu_ip_block
> *ip_block)
> switch (amdgpu_ip_version(adev, SDMA0_HWIP, 0)) {
> case IP_VERSION(7, 0, 0):
> case IP_VERSION(7, 0, 1):
> - if ((adev->sdma.instance[0].fw_version >= 7836028) &&
> !adev->sdma.disable_uq)
> + if ((adev->sdma.instance[0].fw_version >= 7966358) &&
> !adev->sdma.disable_uq)
> adev->userq_funcs[AMDGPU_HW_IP_DMA] =
> &userq_mes_funcs;
> break;
> default:
> --
> 2.49.0
>
