Re: [PATCH] drm/amdgpu: Add NULL check for asic_funcs

[Alex Deucher]

On Fri, Jul 18, 2025 at 12:08 AM Lijo Lazar <lijo.la...@amd.com> wrote:
>
> If driver load fails too early, asic_funcs pointer remains unassigned.
> Add NULL check to sanitize unwind path.
>
> Signed-off-by: Lijo Lazar <lijo.la...@amd.com>

Acked-by: Alex Deucher <alexander.deuc...@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c
> index e56ba93a8df6..a974265837f0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c
> @@ -55,7 +55,8 @@ u64 amdgpu_nbio_get_pcie_replay_count(struct amdgpu_device 
> *adev)
>
>  bool amdgpu_nbio_is_replay_cnt_supported(struct amdgpu_device *adev)
>  {
> -       if (amdgpu_sriov_vf(adev) || !adev->asic_funcs->get_pcie_replay_count 
> ||
> +       if (amdgpu_sriov_vf(adev) || !adev->asic_funcs ||
> +           !adev->asic_funcs->get_pcie_replay_count ||
>             (!adev->nbio.funcs || !adev->nbio.funcs->get_pcie_replay_count))
>                 return false;
>
> --
> 2.49.0
>