On 7/15/2025 11:15 AM, Asad Kamal wrote:
> Remove unnecessary variable ret from smu_v13_0_12_get_smu_metrics_data
>
> Reported-by: kernel test robot <[email protected]>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/[email protected]
>
> Signed-off-by: Asad Kamal <[email protected]>
Reviewed-by: Lijo Lazar <[email protected]>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
> index b3adeb6e43a8..02a455a31c25 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
> @@ -301,7 +301,6 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context
> *smu,
> struct smu_table_context *smu_table = &smu->smu_table;
> MetricsTable_t *metrics = (MetricsTable_t *)smu_table->metrics_table;
> struct amdgpu_device *adev = smu->adev;
> - int ret = 0;
> int xcc_id;
>
> /* For clocks with multiple instances, only report the first one */
> @@ -357,7 +356,7 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context
> *smu,
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> ssize_t smu_v13_0_12_get_xcp_metrics(struct smu_context *smu, struct
> amdgpu_xcp *xcp, void *table, void *smu_metrics)
