On 6/17/25 05:07, Alex Deucher wrote: > We need to know the wptr and sequence number associated > with a job so that we can re-emit the unprocessed state
I suggest to replace job with fence here and in the subject line. > after a ring reset. Pre-allocate storage space for > the ring buffer contents and add helpers to save off > and re-emit the unprocessed state so that it can be > re-emitted after the queue is reset. > > Signed-off-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 90 +++++++++++++++++++++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 14 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 59 +++++++++++++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 17 +++++ > 5 files changed, 181 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > index 5555f3ae08c60..b8d51ee60adcc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > @@ -120,11 +120,13 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct > dma_fence **f, > am_fence = kmalloc(sizeof(*am_fence), GFP_KERNEL); > if (!am_fence) > return -ENOMEM; > + am_fence->context = 0; > } else { > am_fence = af; > } > fence = &am_fence->base; > am_fence->ring = ring; > + am_fence->wptr = 0; > > seq = ++ring->fence_drv.sync_seq; > if (af) { > @@ -253,6 +255,7 @@ bool amdgpu_fence_process(struct amdgpu_ring *ring) > > do { > struct dma_fence *fence, **ptr; > + struct amdgpu_fence *am_fence; > > ++last_seq; > last_seq &= drv->num_fences_mask; > @@ -265,6 +268,9 @@ bool amdgpu_fence_process(struct amdgpu_ring *ring) > if (!fence) > continue; > > + am_fence = container_of(fence, struct amdgpu_fence, base); > + if (am_fence->wptr) > + drv->last_wptr = am_fence->wptr; > dma_fence_signal(fence); > dma_fence_put(fence); > pm_runtime_mark_last_busy(adev_to_drm(adev)->dev); > @@ -725,6 +731,90 @@ void amdgpu_fence_driver_force_completion(struct > amdgpu_ring *ring) > amdgpu_fence_process(ring); > } > > +/** > + * amdgpu_fence_driver_guilty_force_completion - force signal of specified > sequence > + * > + * @fence: fence of the ring to signal > + * > + */ > +void amdgpu_fence_driver_guilty_force_completion(struct amdgpu_fence *fence) > +{ > + dma_fence_set_error(&fence->base, -ETIME); > + amdgpu_fence_write(fence->ring, fence->base.seqno); > + amdgpu_fence_process(fence->ring); > +} > + > +void amdgpu_fence_save_wptr(struct dma_fence *fence) > +{ > + struct amdgpu_fence *am_fence = container_of(fence, struct > amdgpu_fence, base); > + > + am_fence->wptr = am_fence->ring->wptr; > +} > + > +static void amdgpu_ring_backup_unprocessed_command(struct amdgpu_ring *ring, > + unsigned int idx, > + u64 start_wptr, u32 end_wptr) > +{ > + unsigned int first_idx = start_wptr & ring->buf_mask; > + unsigned int last_idx = end_wptr & ring->buf_mask; > + unsigned int i, j, entries_to_copy; > + > + if (last_idx < first_idx) { > + entries_to_copy = ring->buf_mask + 1 - first_idx; > + for (i = 0; i < entries_to_copy; i++) > + ring->ring_backup[idx + i] = ring->ring[first_idx + i]; > + ring->ring_backup_entries_to_copy += entries_to_copy; > + entries_to_copy = last_idx; > + for (j = 0; j < entries_to_copy; j++) > + ring->ring_backup[idx + i + j] = ring->ring[j]; > + ring->ring_backup_entries_to_copy += entries_to_copy; > + } else { > + entries_to_copy = last_idx - first_idx; > + for (i = 0; i < entries_to_copy; i++) > + ring->ring_backup[idx + i] = ring->ring[first_idx + i]; > + ring->ring_backup_entries_to_copy += entries_to_copy; > + } That took me a moment to understand. Why not simplyfy it to something like this: unsigned int i, count; for (i = first_idx, count = 0; i != last_idx; ++i, i &= ring->buf_mask, ++count) ring->ring_backup_entries[idx++] = ring->ring[i]; ring->ring_backup_entries_to_copy += count; I need to take a closer look at all the details, and we should probably throw in some documentation here and there. Regards, Christian. > +} > + > +void amdgpu_ring_backup_unprocessed_commands(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence) > +{ > + struct amdgpu_fence *fence; > + struct dma_fence *unprocessed, **ptr; > + u64 wptr, i, seqno; > + > + if (guilty_fence) { > + seqno = guilty_fence->base.seqno; > + wptr = guilty_fence->wptr; > + } else { > + seqno = amdgpu_fence_read(ring); > + wptr = ring->fence_drv.last_wptr; > + } > + ring->ring_backup_entries_to_copy = 0; > + for (i = seqno + 1; i <= ring->fence_drv.sync_seq; ++i) { > + ptr = &ring->fence_drv.fences[i & > ring->fence_drv.num_fences_mask]; > + rcu_read_lock(); > + unprocessed = rcu_dereference(*ptr); > + > + if (unprocessed && !dma_fence_is_signaled(unprocessed)) { > + fence = container_of(unprocessed, struct amdgpu_fence, > base); > + > + /* save everything if the ring is not guilty, otherwise > + * just save the content from other contexts. > + */ > + if (fence->wptr && > + (!guilty_fence || (fence->context != > guilty_fence->context))) { > + amdgpu_ring_backup_unprocessed_command(ring, > + > ring->ring_backup_entries_to_copy, > + wptr, > + > fence->wptr); > + wptr = fence->wptr; > + } > + } > + rcu_read_unlock(); > + } > +} > + > /* > * Common fence implementation > */ > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > index 206b70acb29a0..4e6a598043df8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > @@ -139,7 +139,6 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned > int num_ibs, > int vmid = AMDGPU_JOB_GET_VMID(job); > bool need_pipe_sync = false; > unsigned int cond_exec; > - > unsigned int i; > int r = 0; > > @@ -156,6 +155,12 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, > unsigned int num_ibs, > gds_va = job->gds_va; > init_shadow = job->init_shadow; > af = &job->hw_fence; > + if (job->base.s_fence) { > + struct dma_fence *finished = > &job->base.s_fence->finished; > + af->context = finished->context; > + } else { > + af->context = 0; > + } > } else { > vm = NULL; > fence_ctx = 0; > @@ -309,6 +314,13 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, > unsigned int num_ibs, > > amdgpu_ring_ib_end(ring); > amdgpu_ring_commit(ring); > + > + /* This must be last for resets to work properly > + * as we need to save the wptr associated with this > + * fence. > + */ > + amdgpu_fence_save_wptr(*f); > + > return 0; > } > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > index f0b7080dccb8d..45febdc2f3493 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > @@ -89,8 +89,8 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct > drm_sched_job *s_job) > { > struct amdgpu_ring *ring = to_amdgpu_ring(s_job->sched); > struct amdgpu_job *job = to_amdgpu_job(s_job); > - struct amdgpu_task_info *ti; > struct amdgpu_device *adev = ring->adev; > + struct amdgpu_task_info *ti; > int idx, r; > > if (!drm_dev_enter(adev_to_drm(adev), &idx)) { > @@ -135,7 +135,7 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct > drm_sched_job *s_job) > } else if (amdgpu_gpu_recovery && ring->funcs->reset) { > dev_err(adev->dev, "Starting %s ring reset\n", > s_job->sched->name); > - r = amdgpu_ring_reset(ring, job->vmid, NULL); > + r = amdgpu_ring_reset(ring, job->vmid, &job->hw_fence); > if (!r) { > atomic_inc(&ring->adev->gpu_reset_counter); > dev_err(adev->dev, "Ring %s reset succeeded\n", > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > index 426834806fbf2..0985eba010e17 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -333,6 +333,12 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct > amdgpu_ring *ring, > /* Initialize cached_rptr to 0 */ > ring->cached_rptr = 0; > > + if (!ring->ring_backup) { > + ring->ring_backup = kvzalloc(ring->ring_size, GFP_KERNEL); > + if (!ring->ring_backup) > + return -ENOMEM; > + } > + > /* Allocate ring buffer */ > if (ring->ring_obj == NULL) { > r = amdgpu_bo_create_kernel(adev, ring->ring_size + > ring->funcs->extra_dw, PAGE_SIZE, > @@ -342,6 +348,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct > amdgpu_ring *ring, > (void **)&ring->ring); > if (r) { > dev_err(adev->dev, "(%d) ring create failed\n", r); > + kvfree(ring->ring_backup); > return r; > } > amdgpu_ring_clear_ring(ring); > @@ -385,6 +392,8 @@ void amdgpu_ring_fini(struct amdgpu_ring *ring) > amdgpu_bo_free_kernel(&ring->ring_obj, > &ring->gpu_addr, > (void **)&ring->ring); > + kvfree(ring->ring_backup); > + ring->ring_backup = NULL; > > dma_fence_put(ring->vmid_wait); > ring->vmid_wait = NULL; > @@ -753,3 +762,53 @@ bool amdgpu_ring_sched_ready(struct amdgpu_ring *ring) > > return true; > } > + > +static int amdgpu_ring_reemit_unprocessed_commands(struct amdgpu_ring *ring) > +{ > + unsigned int i; > + int r; > + > + /* re-emit the unprocessed ring contents */ > + if (ring->ring_backup_entries_to_copy) { > + r = amdgpu_ring_alloc(ring, ring->ring_backup_entries_to_copy); > + if (r) > + return r; > + for (i = 0; i < ring->ring_backup_entries_to_copy; i++) > + amdgpu_ring_write(ring, ring->ring_backup[i]); > + amdgpu_ring_commit(ring); > + } > + > + return 0; > +} > + > +void amdgpu_ring_reset_helper_begin(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence) > +{ > + /* Stop the scheduler to prevent anybody else from touching the ring > buffer. */ > + drm_sched_wqueue_stop(&ring->sched); > + /* back up the non-guilty commands */ > + amdgpu_ring_backup_unprocessed_commands(ring, guilty_fence); > +} > + > +int amdgpu_ring_reset_helper_end(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence) > +{ > + int r; > + > + /* verify that the ring is functional */ > + r = amdgpu_ring_test_ring(ring); > + if (r) > + return r; > + > + /* signal the fence of the bad job */ > + if (guilty_fence) > + amdgpu_fence_driver_guilty_force_completion(guilty_fence); > + /* Re-emit the non-guilty commands */ > + r = amdgpu_ring_reemit_unprocessed_commands(ring); > + if (r) > + /* if we fail to reemit, force complete all fences */ > + amdgpu_fence_driver_force_completion(ring); > + /* Start the scheduler again */ > + drm_sched_wqueue_start(&ring->sched); > + return 0; > +} > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h > index 6aaa9d0c1f25c..dcf20adda2f36 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h > @@ -118,6 +118,7 @@ struct amdgpu_fence_driver { > /* sync_seq is protected by ring emission lock */ > uint32_t sync_seq; > atomic_t last_seq; > + u64 last_wptr; > bool initialized; > struct amdgpu_irq_src *irq_src; > unsigned irq_type; > @@ -141,6 +142,11 @@ struct amdgpu_fence { > /* RB, DMA, etc. */ > struct amdgpu_ring *ring; > ktime_t start_timestamp; > + > + /* wptr for the fence for resets */ > + u64 wptr; > + /* fence context for resets */ > + u64 context; > }; > > extern const struct drm_sched_backend_ops amdgpu_sched_ops; > @@ -148,6 +154,8 @@ extern const struct drm_sched_backend_ops > amdgpu_sched_ops; > void amdgpu_fence_driver_clear_job_fences(struct amdgpu_ring *ring); > void amdgpu_fence_driver_set_error(struct amdgpu_ring *ring, int error); > void amdgpu_fence_driver_force_completion(struct amdgpu_ring *ring); > +void amdgpu_fence_driver_guilty_force_completion(struct amdgpu_fence *fence); > +void amdgpu_fence_save_wptr(struct dma_fence *fence); > > int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring); > int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring, > @@ -284,6 +292,9 @@ struct amdgpu_ring { > > struct amdgpu_bo *ring_obj; > uint32_t *ring; > + /* backups for resets */ > + uint32_t *ring_backup; > + unsigned int ring_backup_entries_to_copy; > unsigned rptr_offs; > u64 rptr_gpu_addr; > volatile u32 *rptr_cpu_addr; > @@ -550,4 +561,10 @@ int amdgpu_ib_pool_init(struct amdgpu_device *adev); > void amdgpu_ib_pool_fini(struct amdgpu_device *adev); > int amdgpu_ib_ring_tests(struct amdgpu_device *adev); > bool amdgpu_ring_sched_ready(struct amdgpu_ring *ring); > +void amdgpu_ring_backup_unprocessed_commands(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence); > +void amdgpu_ring_reset_helper_begin(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence); > +int amdgpu_ring_reset_helper_end(struct amdgpu_ring *ring, > + struct amdgpu_fence *guilty_fence); > #endif
