[AMD Official Use Only - AMD Internal Distribution Only] Hi @Deucher, Alexander，
Could you help review this patch? The update of include/uapi/drm/amdgpu_drm.h needs your Reviewed-by, thanks. Regards, Tao > -----Original Message----- > From: Zhou1, Tao <[email protected]> > Sent: Wednesday, April 30, 2025 4:26 PM > To: [email protected] > Cc: Zhou1, Tao <[email protected]>; Zhang, Hawking > <[email protected]> > Subject: [PATCH 1/7] drm/amd: add definition for new memory type > > Support new version of HBM. > > Signed-off-by: Tao Zhou <[email protected]> > Reviewed-by: Hawking Zhang <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++ > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- > drivers/gpu/drm/amd/include/atomfirmware.h | 1 + > include/uapi/drm/amdgpu_drm.h | 1 + > 4 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c > index eb015bdda8a7..c7d32fb216e4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c > @@ -281,6 +281,9 @@ static int convert_atom_mem_type_to_vram_type(struct > amdgpu_device *adev, > case ATOM_DGPU_VRAM_TYPE_GDDR6: > vram_type = AMDGPU_VRAM_TYPE_GDDR6; > break; > + case ATOM_DGPU_VRAM_TYPE_HBM3E: > + vram_type = AMDGPU_VRAM_TYPE_HBM3E; > + break; > default: > vram_type = AMDGPU_VRAM_TYPE_UNKNOWN; > break; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index bd6005cc06c0..4b8c492348b0 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -1080,7 +1080,8 @@ static const char * const amdgpu_vram_names[] = { > "GDDR6", > "DDR5", > "LPDDR4", > - "LPDDR5" > + "LPDDR5", > + "HBM3E" > }; > > /** > diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h > b/drivers/gpu/drm/amd/include/atomfirmware.h > index 0160d65f3f5e..5c293017b541 100644 > --- a/drivers/gpu/drm/amd/include/atomfirmware.h > +++ b/drivers/gpu/drm/amd/include/atomfirmware.h > @@ -183,6 +183,7 @@ enum atom_dgpu_vram_type { > ATOM_DGPU_VRAM_TYPE_HBM2E = 0x61, > ATOM_DGPU_VRAM_TYPE_GDDR6 = 0x70, > ATOM_DGPU_VRAM_TYPE_HBM3 = 0x80, > + ATOM_DGPU_VRAM_TYPE_HBM3E = 0x81, > }; > > enum atom_dp_vs_preemph_def{ > diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h > index > adb811ed4c34..f3223c05f71c 100644 > --- a/include/uapi/drm/amdgpu_drm.h > +++ b/include/uapi/drm/amdgpu_drm.h > @@ -1443,6 +1443,7 @@ struct drm_amdgpu_info_vbios { #define > AMDGPU_VRAM_TYPE_DDR5 10 #define AMDGPU_VRAM_TYPE_LPDDR4 11 > #define AMDGPU_VRAM_TYPE_LPDDR5 12 > +#define AMDGPU_VRAM_TYPE_HBM3E 13 > > #define AMDGPU_VRAM_TYPE_HBM_WIDTH 4096 > > -- > 2.34.1
