Re: [PATCH 1/2] drm/amdgpu: Enable per-queue reset for SDMA v4.4.2 on IP v9.5.0

[Lazar, Lijo]

On 4/3/2025 3:13 PM, jesse.zh...@amd.com wrote:
> Add support for per-queue reset on SDMA v4.4.2 when running with:
> 1. MEC firmware version 0xb0 or later

This is not correct the version. Firmware team mentioned Rev 15.

Thanks,
Lijo

> 2. DPM indicates SDMA reset is supported
> 
> Signed-off-by: Jesse.Zhang <jesse.zh...@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c 
> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> index 688a720bbbbd..9a2a5eb93763 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> @@ -2373,7 +2373,9 @@ static void sdma_v4_4_2_update_reset_mask(struct 
> amdgpu_device *adev)
>                       adev->sdma.supported_reset |= 
> AMDGPU_RESET_TYPE_PER_QUEUE;
>               break;
>       case IP_VERSION(9, 5, 0):
> -             /*TODO: enable the queue reset flag until fw supported */
> +             if ((adev->gfx.mec_fw_version >= 0xb0) && 
> amdgpu_dpm_reset_sdma_is_supported(adev))
> +                     adev->sdma.supported_reset |= 
> AMDGPU_RESET_TYPE_PER_QUEUE;
> +             break;
>       default:
>               break;
>       }