Am 24.02.25 um 12:45 schrieb Srinivasan Shanmugam: > This commit updates the documentation for the function > amdgpu_sdma_register_on_reset_callbacks to include a description > for the 'adev' parameter. > > The 'adev' parameter is a pointer to the amdgpu_device structure, > which is necessary for registering SDMA reset callbacks. > > Fixes the below with gcc W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:474: warning: Function parameter or > struct member 'adev' not described in > 'amdgpu_sdma_register_on_reset_callbacks' > > Cc: Christian König <[email protected]> > Cc: Alex Deucher <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > index 42a7b86e41c3..82856592039b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > @@ -464,6 +464,7 @@ void amdgpu_sdma_sysfs_reset_mask_fini(struct > amdgpu_device *adev) > > /** > * amdgpu_sdma_register_on_reset_callbacks - Register SDMA reset callbacks
Why do we have a function to dynamically register callbacks in the first place? That doesn't seem to make much sense. Regards, Christian. > + * @adev: Pointer to the amdgpu_device structure > * @funcs: Pointer to the callback structure containing pre_reset and > post_reset functions > * > * This function allows KFD and AMDGPU to register their own callbacks for > handling
