When compiling on LoongArch, there exists the following objtool
warning in arch/loongarch/kernel/machine_kexec.o:

  kexec_reboot() falls through to next function crash_shutdown_secondary()

Avoid unreachable() as it can (and will in the absence of UBSAN)
generate fallthrough code. Use BUG() so we get a "break BRK_BUG"
trap (with unreachable annotation).

Signed-off-by: Tiezhu Yang <[email protected]>
---
 arch/loongarch/kernel/machine_kexec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/loongarch/kernel/machine_kexec.c 
b/arch/loongarch/kernel/machine_kexec.c
index 8ae641dc53bb..f9381800e291 100644
--- a/arch/loongarch/kernel/machine_kexec.c
+++ b/arch/loongarch/kernel/machine_kexec.c
@@ -126,14 +126,14 @@ void kexec_reboot(void)
        /* All secondary cpus go to kexec_smp_wait */
        if (smp_processor_id() > 0) {
                relocated_kexec_smp_wait(NULL);
-               unreachable();
+               BUG();
        }
 #endif
 
        do_kexec = (void *)reboot_code_buffer;
        do_kexec(efi_boot, cmdline_ptr, systable_ptr, start_addr, 
first_ind_entry);
 
-       unreachable();
+       BUG();
 }
 
 
-- 
2.42.0

Reply via email to